Feature: (Ping - Host up/down) Notifications#3471
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces user-configurable status change notifications for Ping Monitor (stackable popup + optional throttled system sound) and includes a couple of related UI/UX fixes (Ping Monitor “Status change” time formatting; Status Window close-timer behavior).
Changes:
- Added a new notification system (popup window + manager) and wired Ping Monitor status transitions to trigger popups/sounds with configurable thresholds.
- Extended Ping Monitor settings + persisted settings defaults for notification behavior (popup, sound, thresholds, duration).
- Fixed Ping Monitor “Status change” display formatting and corrected Status Window auto-close timer behavior.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Website/docs/changelog/next-release.md | Documents the new Ping Monitor notifications feature and related fixes in the next release notes. |
| Website/docs/application/ping-monitor.md | Adds user documentation for Ping Monitor notifications and their settings. |
| Source/NETworkManager/Views/PingMonitorView.xaml | Fixes “Status change” display to show time-of-day as HH:mm:ss. |
| Source/NETworkManager/Views/PingMonitorSettingsView.xaml | Adds UI controls for notification popup/sound, thresholds, and duration. |
| Source/NETworkManager/ViewModels/PingMonitorViewModel.cs | Implements thresholded status-change detection and triggers notification popup/sound. |
| Source/NETworkManager/ViewModels/PingMonitorSettingsViewModel.cs | Exposes new notification-related settings for binding and persistence. |
| Source/NETworkManager/StatusWindow.xaml.cs | Fixes enableCloseTimer handling so manually opened Status Window doesn’t auto-close. |
| Source/NETworkManager/NotificationWindow.xaml.cs | Implements the stackable notification popup window behavior (timer/progress/interaction). |
| Source/NETworkManager/NotificationWindow.xaml | Defines the notification popup UI (icon, title/time, message, close button, progress bar). |
| Source/NETworkManager/NotificationManager.cs | Adds a manager for stacking popups and throttling notification sounds. |
| Source/NETworkManager.Settings/SettingsInfo.cs | Adds persisted settings properties for Ping Monitor notifications. |
| Source/NETworkManager.Settings/GlobalStaticConfiguration.cs | Adds defaults for Ping Monitor notification settings and sound throttle interval. |
| Source/NETworkManager.Localization/Resources/Strings.resx | Adds new localized strings for notification settings UI and messages. |
| Source/NETworkManager.Localization/Resources/Strings.Designer.cs | Updates generated strongly-typed accessors for new localization keys. |
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…oBeRoot/NETworkManager into feature/notifications-ping
BornToBeRoot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request introduces a new, reusable notification popup system for the application, allowing for stackable, customizable notifications (such as status change alerts) in the bottom-right corner of the screen. It adds both the UI and logic for these notifications, provides new settings for notification behavior, and localizes the relevant strings. The most important changes are:
Notification Popup System:
NotificationManagerclass that manages the display and stacking of notification popups, including sound throttling to prevent audio spam from bursts of status changes. (Source/NETworkManager/NotificationManager.cs)NotificationWindowWPF window, with customizable icon, color, title, message, and auto-close timer, including logic for positioning, stacking, and user interaction (click to open main window, close button, etc.). (Source/NETworkManager/NotificationWindow.xaml,Source/NETworkManager/NotificationWindow.xaml.cs) [1] [2]Settings and Configuration:
Source/NETworkManager.Settings/GlobalStaticConfiguration.cs) [1] [2]SettingsInfoclass with properties for user-configurable notification settings, supporting property change notifications for UI binding. (Source/NETworkManager.Settings/SettingsInfo.cs)Localization:
Source/NETworkManager.Localization/Resources/Strings.resx,Source/NETworkManager.Localization/Resources/Strings.Designer.cs) [1] [2]To-Do
Contributing
By submitting this pull request, I confirm the following: